Skip to content

[Issue #337] replaced Poly_Order by format_poly#338

Merged
Didou09 merged 3 commits intodevelfrom
Issue#337-polyorder
Jan 28, 2020
Merged

[Issue #337] replaced Poly_Order by format_poly#338
Didou09 merged 3 commits intodevelfrom
Issue#337-polyorder

Conversation

@lasofivec
Copy link
Copy Markdown
Collaborator

Replaced Poly_Order by format_poly:

  • the function now doesn't change the layout of the polygon: a polygon should always be in the format (cc,N) = (number_of_coordinates, number_of_points)
  • the tests were adapted
  • calls were updated

Solves #337

@lasofivec lasofivec requested a review from Didou09 January 28, 2020 10:22
@lasofivec lasofivec self-assigned this Jan 28, 2020
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Jan 28, 2020

Hello @lasofivec! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-01-28 10:26:53 UTC

Copy link
Copy Markdown
Member

@Didou09 Didou09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ! Thanks !

@Didou09 Didou09 merged commit 6147320 into devel Jan 28, 2020
@Didou09 Didou09 deleted the Issue#337-polyorder branch January 28, 2020 13:03
@Didou09 Didou09 mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants