Skip to content

Updating devel with master changes#342

Merged
Didou09 merged 9 commits intodevelfrom
master
Feb 5, 2020
Merged

Updating devel with master changes#342
Didou09 merged 9 commits intodevelfrom
master

Conversation

@lasofivec
Copy link
Copy Markdown
Collaborator

@lasofivec lasofivec commented Feb 5, 2020

We pushed some changes directly into master (there might be a couple of pushes to come).
This PR is just to update devel with the latest changes. Mainly:

  • Changes on packaging technique for shorter builds and right deployment to anaconda

  • Added docstr to some function

  • Added extra keyword argument to tofuplot and tofucalc for finer user tuneability

@lasofivec lasofivec requested a review from Didou09 February 5, 2020 14:04
@lasofivec lasofivec self-assigned this Feb 5, 2020
@pep8speaks
Copy link
Copy Markdown

Hello @lasofivec! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1270:80: E501 line too long (80 > 79 characters)
Line 3897:35: E702 multiple statements on one line (semicolon)
Line 3897:52: E261 at least two spaces before inline comment

Line 1181:21: E116 unexpected indentation (comment)
Line 1182:25: E116 unexpected indentation (comment)
Line 1183:29: E116 unexpected indentation (comment)
Line 1184:29: E116 unexpected indentation (comment)
Line 1185:33: E116 unexpected indentation (comment)

Line 160:80: E501 line too long (83 > 79 characters)

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 5, 2020

Codecov Report

Merging #342 into devel will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #342      +/-   ##
==========================================
- Coverage   40.02%   39.97%   -0.06%     
==========================================
  Files          79       79              
  Lines       24134    24128       -6     
==========================================
- Hits         9659     9644      -15     
- Misses      14475    14484       +9
Impacted Files Coverage Δ
tofu/imas2tofu/_core.py 0.67% <0%> (-0.01%) ⬇️
tofu/utils.py 48.15% <0%> (+0.22%) ⬆️
tofu/data/_core_new.py 13.15% <0%> (-0.47%) ⬇️
tofu/geom/_core_optics.py 14.35% <0%> (-0.35%) ⬇️
tofu/geom/_comp.py 59.69% <0%> (-0.22%) ⬇️
tofu/data/_core.py 38.79% <0%> (-0.18%) ⬇️
tofu/geom/_plot.py 64.98% <0%> (-0.11%) ⬇️
tofu/geom/_core.py 62.98% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05ba14f...45b1595. Read the comment docs.

@Didou09 Didou09 merged commit 3adee50 into devel Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants