feat: broken test PR#49
Open
DanySK wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the NGINX API gateway container healthcheck configuration.
Changes:
- Changed the
api-gatewayhealthcheck URL from/healthto/plutopaperino.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| restart: unless-stopped | ||
| healthcheck: | ||
| test: ['CMD', 'wget', '-q', '-O', '/dev/null', 'http://localhost/health'] | ||
| test: ['CMD', 'wget', '-q', '-O', '/dev/null', 'http://localhost/plutopaperino'] |
There was a problem hiding this comment.
The NGINX container healthcheck now calls http://localhost/plutopaperino, but the bundled nginx.conf only exposes a location = /health endpoint. This will cause the container to remain unhealthy (and any depends_on: condition: service_healthy chains to fail). Update the healthcheck URL back to /health (or add a matching location in nginx.conf if the endpoint is intentionally changing).
Suggested change
| test: ['CMD', 'wget', '-q', '-O', '/dev/null', 'http://localhost/plutopaperino'] | |
| test: ['CMD', 'wget', '-q', '-O', '/dev/null', 'http://localhost/health'] |
renovate
Bot
force-pushed
the
renovate/nginx-1.x
branch
from
60812e1 to
76c37b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.