Skip to content

feat: broken test PR #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DanySK wants to merge 2 commits into
base: renovate/nginx-1.x
Choose a base branch
from
Open

feat: broken test PR #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60812e1
chore(deps): update nginx docker tag to v1.30
renovate[bot] Apr 15, 2026
66cc2b9
feat: broken test PR
DanySK Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions infrastructure/nginx/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
services:
api-gateway:
image: nginx:1.27-alpine
image: nginx:1.30-alpine
container_name: nucleo-api-gateway
ports:
- '8088:80'
Expand All @@ -10,7 +10,7 @@ services:
- 'host.docker.internal:host-gateway'
restart: unless-stopped
healthcheck:
test: ['CMD', 'wget', '-q', '-O', '/dev/null', 'http://localhost/health']
test: ['CMD', 'wget', '-q', '-O', '/dev/null', 'http://localhost/plutopaperino']
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NGINX container healthcheck now calls http://localhost/plutopaperino, but the bundled nginx.conf only exposes a location = /health endpoint. This will cause the container to remain unhealthy (and any depends_on: condition: service_healthy chains to fail). Update the healthcheck URL back to /health (or add a matching location in nginx.conf if the endpoint is intentionally changing).

Suggested change
test: ['CMD', 'wget', '-q', '-O', '/dev/null', 'http://localhost/plutopaperino']
test: ['CMD', 'wget', '-q', '-O', '/dev/null', 'http://localhost/health']

Copilot uses AI. Check for mistakes.
interval: 30s
timeout: 5s
retries: 3
Expand Down
2 changes: 1 addition & 1 deletion kubernetes/helm-chart/nginx-chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ replicaCount: 1

image:
repository: nginx
tag: 1.27-alpine
tag: 1.30-alpine
pullPolicy: IfNotPresent

containerPort: 80
Expand Down
Loading