Floodgate players are not detected at JoinManagement on BungeeCord

[Smart123s]

What happened?

The Bukkit part of the server is irrelevant, because the Player gets kicked before reaching it.

This happens randomly (around 50% of the time), if the player is not yet in the Floodgate.getPlayers() list when doing the name conflict checking:
https://github.com/games647/FastLogin/blob/01c9b55d80c93e0df4ad9050519995f4d56db759/core/src/main/java/com/github/games647/fastlogin/core/shared/JoinManagement.java#L61

If this line returns null, it means that he/she is a Java Player, and they'll be treated as one. Because my Bedrock username is the same as my Java username, I'm treated as a Premium player. Because of that, FastLogin will try to log in the Floodgate players as if they were a Premium Java players, which causes the errors that I've attached in the logs below.

I have experimented quite a bit with the code, and found out the following:

• The username variable in...
  https://github.com/games647/FastLogin/blob/01c9b55d80c93e0df4ad9050519995f4d56db759/core/src/main/java/com/github/games647/fastlogin/core/shared/JoinManagement.java#L53
  ...sometimes contains the Floodgate prefix, sometimes it doesn't.

• connection.getUniqueId() is null at the PreLogin event, although it should have been initialized by Floodgate.

  • Why should it have a value?
    • Floodgate's PreLogin event priority is LOWEST while FastLogin's is unset (=NORMAL).
    • This was in the docs of the Floodgate 1.0 implementation of FastLogin
      https://github.com/games647/FastLogin/blob/d6a02aa5385ef7eb6c8b2f2169dfae1a351ef5b8/bungee/src/main/java/com/github/games647/fastlogin/bungee/listener/ConnectListener.java#L211-L213
    • And it is in fact, still true for Floodgate 2.0 (UUID setting code)
  • Why doesn't it have a value?
    • I don't know. Please help me out. Am I the one who doesn't see something, or did Bungee forget how EventPriority works?

What did you expect?

No response

Steps to reproduce

No response

Plugin list

Geyser, Floodgate, SQLite-for-BungeeCord

Configuration file

not loaded by the plugin at this point of the code

Server log

https://pastebin.com/FjNK7Wd7

Plugin version

056b8a7 (#602)

Platform

BungeeCord

Relevance

• I tried the latest build
• I checked for existing tickets -
  If there are, please vote them with a thumps reaction and not create new ones

[TuxCoding]

I don't know. Please help me out. Am I the one who doesn't see something, or did Bungee forget how EventPriority works?

It could be related to the fact that FastLogin runs this code asynchronously. Then there could be a race condition, where two threads compete in each other. The issue sounds like that, but as far as I know Floodgate runs synchronously before FastLogin (based on the mentioned priority).

You could try to check if Floodgate actually sets the value by introducing custom debug code.

https://github.com/GeyserMC/Floodgate/blob/2e1b0ba115c5a9f332ded3ff0dd80de74ad51d74/bungee/src/main/java/org/geysermc/floodgate/listener/BungeeListener.java#L102

[Smart123s]

You could try to check if Floodgate actually sets the value by introducing custom debug code.

I have already tried to log it out at the beginning of onPreLogin(), that's how I know it's null.

Then there could be a race condition, where two threads compete in each other.

I will try to debug it... somehow.

Thanks for the advice 😉

[TuxCoding]

I have already tried to log it out at the beginning of onPreLogin(), that's how I know it's null.

I mean in Floodgate to check if it passes this if condition:

        FloodgatePlayer player = channel.attr(playerAttribute).get();
        if (player != null) {

[Smart123s]

I have already tried to log it out at the beginning of onPreLogin(), that's how I know it's null.

I mean in Floodgate to check if it passes this if condition:

        FloodgatePlayer player = channel.attr(playerAttribute).get();
        if (player != null) {

It was not passing.

I have created a new clean server (now on Linux instead of Windows 11) and the issue is gone, so it was just something misbehaving on my end.

[Smart123s]

So it turns out that it wasn't a platform problem after all.

The Floodgate API has always (or at least after a certain update) returned null.
https://github.com/games647/FastLogin/blob/586b357be8860113f9e7d4197e092e50b4d50506/core/src/main/java/com/github/games647/fastlogin/core/shared/JoinManagement.java#L60-L61

The only reason it had worked in some scenarios, is because Floodgate players were treated as cracked Java player, which means that no breaking encryption packets are sent.