Fix plugin messages for Floodgate players #602
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of your change
Previously registration checks for Floodgate players were made via,
authPlugin.isRegistered(username). However, if no auth plugin is installed, that it would have obviously failed. With this PR, if there's no such plugin, it'll try to get the registration status from the SQL Database.Related issue
Fixes #594
I got a lot of
java.lang.IllegalStateException: Cannot reply to EncryptionRequestPacket without profile and access token.errors while trying to join via Bungeecord. It happens randomly (around 50% of the time), if the player is not yet in theFloodgate.getPlayers()list when doing the name conflict checking:https://github.com/games647/FastLogin/blob/01c9b55d80c93e0df4ad9050519995f4d56db759/core/src/main/java/com/github/games647/fastlogin/core/shared/JoinManagement.java#L61
This error is unrelated to the files modified in this PR, so I thought that I'd open
a second PR with the fix#603 because I couldn't figure it out.