Skip to content

feat(API)!: Replace fetch with Node.js 18 module#38

Merged
typeslint-cli[bot] merged 1 commit intoTypeslint:developmentfrom
HarunamiYaki:development
Nov 3, 2023
Merged

feat(API)!: Replace fetch with Node.js 18 module#38
typeslint-cli[bot] merged 1 commit intoTypeslint:developmentfrom
HarunamiYaki:development

Conversation

@HarunamiYaki
Copy link
Copy Markdown
Member

Description

This pull request addresses the issue #34 by Replacing the usage of the 'fetch' function in our codebase with the fetch function provided by the Node.js 18 module.

Changes Made

Removed the fetch function calls from the codebase.
Utilized the fetch function from the Node.js 18 module instead.

@typeslint-cli
Copy link
Copy Markdown
Contributor

typeslint-cli Bot commented Nov 3, 2023

Hello @HarunamiYaki Thank you for submitting Pull Request, please wait for next notification after we review your Pull Request

@typeslint-cli typeslint-cli Bot added Core Pending Unread Issues/PRs labels Nov 3, 2023
Copy link
Copy Markdown
Member

@Muunatic Muunatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@typeslint-cli typeslint-cli Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HarunamiYaki your pull request has been approved by [MAINTAINER]@Muunatic, please type Ready to merge for merging

@typeslint-cli typeslint-cli Bot added Approved Approved PRs and removed Pending Unread Issues/PRs labels Nov 3, 2023
@Muunatic Muunatic added the Major label Nov 3, 2023
@HarunamiYaki
Copy link
Copy Markdown
Member Author

Ready to merge

@typeslint-cli typeslint-cli Bot merged commit e18e222 into Typeslint:development Nov 3, 2023
@typeslint-cli
Copy link
Copy Markdown
Contributor

typeslint-cli Bot commented Nov 3, 2023

Merged by HarunamiYaki!

@Muunatic Muunatic added this to the v3.0.0 milestone Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants