Skip to content

style: change quotes to double quote#39

Merged
typeslint-cli[bot] merged 3 commits intoTypeslint:developmentfrom
Muunatic:development
Nov 6, 2023
Merged

style: change quotes to double quote#39
typeslint-cli[bot] merged 3 commits intoTypeslint:developmentfrom
Muunatic:development

Conversation

@Muunatic
Copy link
Copy Markdown
Member

@Muunatic Muunatic commented Nov 6, 2023

change single quotes to double quote writing style

@Muunatic Muunatic added the Patch label Nov 6, 2023
@typeslint-cli
Copy link
Copy Markdown
Contributor

typeslint-cli Bot commented Nov 6, 2023

Hello @Muunatic Thank you for submitting Pull Request, please wait for next notification after we review your Pull Request

@typeslint-cli typeslint-cli Bot added Core Pending Unread Issues/PRs labels Nov 6, 2023
@Muunatic Muunatic requested a review from HarunamiYaki November 6, 2023 06:42
Copy link
Copy Markdown
Member

@HarunamiYaki HarunamiYaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that a line has been removed in feat(API)!: Replace fetch with Node.js 18 module #38 which should not have been. Could you please remove this line from your changes?

Comment thread src/index.ts Outdated
Copy link
Copy Markdown
Contributor

@typeslint-cli typeslint-cli Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request has requested changes by @HarunamiYaki. PING! @Typeslint Please address their comments before I'm merging this PR, thanks!

@typeslint-cli typeslint-cli Bot added Requested Changes PRs need revision and removed Pending Unread Issues/PRs labels Nov 6, 2023
Co-authored-by: Haruyaki <52639021+HarunamiYaki@users.noreply.github.com>
@typeslint-cli typeslint-cli Bot requested a review from HarunamiYaki November 6, 2023 12:40
@typeslint-cli typeslint-cli Bot removed the Requested Changes PRs need revision label Nov 6, 2023
@typeslint-cli
Copy link
Copy Markdown
Contributor

typeslint-cli Bot commented Nov 6, 2023

PING! @HarunamiYaki. The author has pushed new commits since your last review. please review @Muunatic new commit before merge, thanks!

Copy link
Copy Markdown
Contributor

@typeslint-cli typeslint-cli Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Muunatic your pull request has been approved by [MAINTAINER]@HarunamiYaki, please type Ready to merge for merging

@typeslint-cli typeslint-cli Bot added the Approved Approved PRs label Nov 6, 2023
@Muunatic
Copy link
Copy Markdown
Member Author

Muunatic commented Nov 6, 2023

ready to merge

@typeslint-cli typeslint-cli Bot merged commit 94b6bb8 into Typeslint:development Nov 6, 2023
@typeslint-cli
Copy link
Copy Markdown
Contributor

typeslint-cli Bot commented Nov 6, 2023

Merged by Muunatic!

@Muunatic Muunatic added this to the v3.0.0 milestone Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants