feat: Automatically dismiss stale reviews on pull request open/synchronize#41
Closed
HarunamiYaki wants to merge 1 commit intoTypeslint:developmentfrom
Closed
feat: Automatically dismiss stale reviews on pull request open/synchronize#41HarunamiYaki wants to merge 1 commit intoTypeslint:developmentfrom
HarunamiYaki wants to merge 1 commit intoTypeslint:developmentfrom
Conversation
Contributor
|
Hello @HarunamiYaki Thank you for submitting Pull Request, please wait for next notification after we review your Pull Request |
Member
|
i had to convert it to draft status to testing out this build, if everything looks good i'll approve this pr quickly, thanks! |
Member
|
everything looks good to go. i'm planning to schedule the approval on monday to make sure everything is clear, thanks! @HarunamiYaki |
![typeslint-cli[bot]](https://avatars.githubusercontent.com/in/160439?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
@HarunamiYaki your pull request has been approved by [MAINTAINER]@Muunatic, please type Ready to merge for merging
typeslint-cli
Bot
added
Approved
Member
|
Superseded #42 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new feature to automatically dismiss stale reviews when a pull request is opened or synchronized. In this context, "stale reviews" are considered those that have been submitted with "Requested Changes" or "Approved" status. In addition to introducing the new dismissal feature, this pull request refactors the code for a more concise. The refactored logic now utilizes the
prsLabelsconstant to streamline label checking.