Skip to content

feat: Automatically dismiss stale reviews on pull request open/synchronize #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HarunamiYaki wants to merge 1 commit into from
Closed

feat: Automatically dismiss stale reviews on pull request open/synchronize #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 15 additions & 17 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,7 +802,8 @@ module.exports = (app: Probot) => {
issue_number: context.payload.pull_request.number
}).then(async (res) => {
let i: number;
if (res.data.find(a => a.name == "Requested Changes")) {
const prsLabels = res.data.find(a => a.name == "Requested Changes" || a.name == "Approved")?.name;
if (prsLabels) {
await context.octokit.pulls.listReviews({
owner: context.payload.repository.owner.login,
repo: context.payload.repository.name,
Expand All @@ -821,6 +822,13 @@ module.exports = (app: Probot) => {
const username: string = res.data[i].user?.login || "";
reviewersArray.push(username);
tagReviewers.push("@" + username);
await context.octokit.pulls.dismissReview({
owner: context.payload.repository.owner.login,
repo: context.payload.repository.name,
pull_number: context.payload.pull_request.number,
review_id: res.data[i].id,
message: "This review is stale and has been dismissed."
});
await context.octokit.pulls.requestReviewers({
owner: context.payload.repository.owner.login,
repo: context.payload.repository.name,
Expand All @@ -845,23 +853,13 @@ module.exports = (app: Probot) => {
body: `PING! ${tagReviewers.join(", ")}. The author has pushed new commits since your last review. please review @${context.payload.sender.login} new commit before merge, thanks!`
})
);
await context.octokit.issues.listLabelsOnIssue({
owner: context.payload.repository.owner.login,
repo: context.payload.repository.name,
issue_number: context.payload.pull_request.number
}).then(async (res) => {
if (res.data.find(a => a.name == "Requested Changes")) {
await context.octokit.issues.removeLabel(
context.issue({
name: "Requested Changes"
})
);
} else {
return;
}
});
await context.octokit.issues.removeLabel(
context.issue({
name: prsLabels
})
);
});
} else if (res.data.find(a => a.name == "Approved")) {
} else {
return;
}
});
Expand Down