Skip to content

fix(prsReview): adjust author_association payload#65

Merged
typeslint-cli[bot] merged 1 commit intoTypeslint:developmentfrom
Muunatic:develop
Jun 11, 2024
Merged

fix(prsReview): adjust author_association payload#65
typeslint-cli[bot] merged 1 commit intoTypeslint:developmentfrom
Muunatic:develop

Conversation

@Muunatic
Copy link
Copy Markdown
Member

@Muunatic Muunatic commented Jun 10, 2024

fix wrong payload when reviewPrs

@Muunatic Muunatic added the Patch label Jun 10, 2024
@Muunatic Muunatic requested a review from HarunamiYaki June 10, 2024 03:00
@typeslint-cli
Copy link
Copy Markdown
Contributor

typeslint-cli Bot commented Jun 10, 2024

Hello @Muunatic Thank you for submitting Pull Request, please wait for next notification after we review your Pull Request

@typeslint-cli typeslint-cli Bot added Pending Unread Issues/PRs lib: Pull Request labels Jun 10, 2024
@Muunatic
Copy link
Copy Markdown
Member Author

Muunatic commented Jun 10, 2024

the updated code correctly checks the association of the reviewer, not the pull request author. i'm planning to create a new release once it's merged to fix this bug. could you review and approve this change? @HarunamiYaki

Copy link
Copy Markdown
Member

@HarunamiYaki HarunamiYaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Contributor

@typeslint-cli typeslint-cli Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Muunatic your pull request has been approved by [MAINTAINER]@HarunamiYaki, please type Ready to merge for merging

@typeslint-cli typeslint-cli Bot added Approved Approved PRs and removed Pending Unread Issues/PRs labels Jun 11, 2024
@Muunatic
Copy link
Copy Markdown
Member Author

merge

@typeslint-cli typeslint-cli Bot merged commit 01d2920 into Typeslint:development Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants