Skip to content

fix(prsReview): adjust author_association payload #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typeslint-cli merged 1 commit into from
Jun 11, 2024
Merged

fix(prsReview): adjust author_association payload #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/class/prsReview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export default class PullRequestReview {
await this.createReview(reviewMessage, ["Requested Changes"], ["Pending"]);
}
}
} else if (this.context.payload.pull_request.author_association === "MEMBER" || this.context.payload.pull_request.author_association === "COLLABORATOR") {
} else if (this.context.payload.review.author_association === "MEMBER" || this.context.payload.review.author_association === "COLLABORATOR") {
if (this.context.payload.review.state === "approved") {
const reviewMessage = `@${this.context.payload.pull_request.user.login} your pull request has been approved by \`[MAINTAINER]\`@${this.context.payload.review.user.login}, please type \`Ready to merge\` for merging`;
if (this.context.payload.pull_request.labels.find((a) => a.name === "Requested Changes")) {
Expand Down Expand Up @@ -144,7 +144,7 @@ export default class PullRequestReview {
await this.createReview(reviewMessage, ["Requested Changes"], ["Pending"]);
}
}
} else if (this.context.payload.pull_request.author_association === "MEMBER" || this.context.payload.pull_request.author_association === "COLLABORATOR") {
} else if (this.context.payload.review.author_association === "MEMBER" || this.context.payload.review.author_association === "COLLABORATOR") {
if (this.context.payload.review.state === "approved") {
const reviewMessage = `@${this.context.payload.pull_request.user.login} Pull request has been approved by \`[MAINTAINER]\`@${this.context.payload.review.user.login}, please type \`Merge\` for merging @${this.context.payload.review.user.login}`;
if (this.context.payload.pull_request.labels.find((a) => a.name === "Requested Changes")) {
Expand Down