Merged
Conversation
FinnWilkinson
requested review from
dANW34V3R,
jj16791,
rahahahat and
tom91136
tom91136
requested changes
Oct 27, 2023
tom91136
previously approved these changes
Oct 30, 2023
dANW34V3R
reviewed
Oct 30, 2023
Contributor
dANW34V3R
left a comment
dANW34V3R
left a comment
There was a problem hiding this comment.
Is it worth adding a TODO to remove it later and some explanation of the how this has been updated for newer versions of SST that we don't support yet?
FinnWilkinson
requested review from
ABenC377 and
JosephMoore25
and removed request for
rahahahat
Merged
Contributor
|
I agree with Dan. Looks like this is a temporary fix which can hopefully be removed once SST has been updated. Beyond that, looks good |
ABenC377
previously approved these changes
Oct 31, 2023
Contributor
Author
|
@dANW34V3R @JosephMoore25 TODO comment added. Please check |
JosephMoore25
previously approved these changes
Oct 31, 2023
dANW34V3R
requested changes
Oct 31, 2023
dANW34V3R
approved these changes
Nov 1, 2023
ABenC377
approved these changes
Nov 1, 2023
JosephMoore25
approved these changes
Nov 1, 2023
jj16791
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On more recent versions of MacOS, and more specifically with more recent versions of Apple Clang, SST is unable to be compiled due to
unary_functionandbinary_functiontypes being depricated (since c++11) and now removed from Apple Clang v15. There is a compile flag which re-enabled these types and this has been added toCMakeLists.txtif the user is on MacOS.These functions are only used in SST, and in more recent versions (i.e. SST v13) they have been replaced - so this issue may only be short term if SimEng's SST support is updated to version 13+