Merged
Conversation
Contributor
|
Looks mostly good, but tiny code inconsistency. You define "const Architecture& arch = instruction_.getArchitecture();" but then still use instruction_.getArchitecture() a couple lines later and then switch to arch a bit later. Probs best to just stick to one or the other for the sake of consistency. |
ABenC377
reviewed
Oct 31, 2023
ABenC377
previously approved these changes
Oct 31, 2023
Contributor
ABenC377
left a comment
There was a problem hiding this comment.
Can 'instruction_.getArchitecture()' in ExceptionHandler.cc line 661 be replaced with the 'arch' variable declared above it?
Contributor
Author
|
@JosephMoore25 @ABenC377 Good spot, will change this now |
JosephMoore25
previously approved these changes
Oct 31, 2023
144e864 to
db268f2
Compare
…r for an instruction's source operands.
… properly and so that changes to SM or ZA bits are checked before zeroing out SVE / SME registers.
db268f2 to
bf63187
Compare
dANW34V3R
approved these changes
Nov 1, 2023
ABenC377
approved these changes
Nov 1, 2023
JosephMoore25
approved these changes
Nov 1, 2023
jj16791
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR for the most part addresses issue #329 - correcting the SVCR and Streaming Mode logic introduced with SME. This is summaried as:
msr svcr, xtinstruction in addition tosmstart/smstop/msr svcr, #immAdditional to this, logic for the NEON muti-struct store with post index instructions introduced in PR #335 has been corrected via a small change to the metadata to correctly identify if a
#immorxtis used as said post index.NOTE: this branch is based on
macos-sst-build-fixand thus contains the fixes present in PR #338. This PR will be rebased todevonce PR #338 has been merged and should be merged intodevafter PR #338.