Merged
Conversation
jj16791
added
bug
jj16791
requested review from
FinnWilkinson,
JosephMoore25,
dANW34V3R and
rahahahat
This was
linked to
issues
Dec 16, 2023
Merged
dANW34V3R
previously approved these changes
Dec 18, 2023
Contributor
dANW34V3R
left a comment
dANW34V3R
left a comment
There was a problem hiding this comment.
Good find, simple fix and well documented
JosephMoore25
previously approved these changes
Dec 18, 2023
Contributor
JosephMoore25
left a comment
JosephMoore25
left a comment
There was a problem hiding this comment.
Clear fixes, well commented, and looks good to be merged
jj16791
dismissed stale reviews from JosephMoore25 and dANW34V3R
via
2c08dea
FinnWilkinson
requested changes
Dec 19, 2023
FinnWilkinson
approved these changes
Dec 19, 2023
dANW34V3R
approved these changes
Dec 19, 2023
JosephMoore25
approved these changes
Dec 19, 2023
Contributor
Author
|
#rerun tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Within this PR, various identified bugs in
devare resolved. These include:sve_merge_store_dataassumed the vector and memory elements were the same width which is false.sve_merge_store_datanow takes a secondary typename to describe the width of the memory elements.RUNcalls in the regression test suite. The process memory is now zeroed out before populating it.Registerstruct now has an extra boolean attribute to describe whether its been generated as part of a renaming scheme. Only those registers with this attribute set to true will be rewound when the ROB is flushed.Resolves #360, resolves #361, resolves #362