Merged
Conversation
…ts of both AArch64 and RISC-V classes.
…ation ending clause.
…on ending condition.
jj16791
reviewed
Jan 25, 2024
jj16791
requested changes
Jan 25, 2024
jj16791
previously approved these changes
Jan 27, 2024
Closed
Closed
JosephMoore25
previously approved these changes
Jan 31, 2024
Contributor
JosephMoore25
left a comment
JosephMoore25
left a comment
There was a problem hiding this comment.
Couldn't spot anything that needs changing, looks all good - nice work.
Only thing to consider, although not worth blocking this PR over, is the files src/include/simeng/arch/aarch64/helpers/load.hh and store.hh. These are empty templates for future helper functions, so should either be removed until needed or ideally a ToDo added in each to explain why they're there, although perhaps this can be handled in a future cleanup PR instead.
dANW34V3R
reviewed
Feb 2, 2024
Contributor
dANW34V3R
left a comment
dANW34V3R
left a comment
There was a problem hiding this comment.
Is there a way we can quantify our coverage now that these tests are implemented?
FinnWilkinson
dismissed stale reviews from JosephMoore25, ABenC377, and jj16791
via
9d6e581
jj16791
requested changes
Feb 2, 2024
…yInterface unit tests.
…ncyMemoryInterface unit tests.
jj16791
approved these changes
Feb 2, 2024
JosephMoore25
approved these changes
Feb 2, 2024
dANW34V3R
approved these changes
Feb 2, 2024
This was referenced Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aims to update the Unit test suite of SimEng such that all classes have comprehensive coverage of their functionality tested. Closes #340
No tests have been added / updated for the following classes due to radical changes / replacement in current Pull Requests or in the very near future:
MicroOperation.ccregression testsdecode(as of this PR) are now private - this change was made to conform to standard OOP practices; given they are only used within the class itself.This PR also contains a fixes for issues #365, #202, #133.