Merged
Conversation
FinnWilkinson
added
code consistency
FinnWilkinson
requested review from
ABenC377,
JosephMoore25,
dANW34V3R and
jj16791
ABenC377
previously approved these changes
Feb 8, 2024
jj16791
requested changes
Feb 8, 2024
jj16791
approved these changes
Feb 8, 2024
FinnWilkinson
force-pushed
the
arch-class-cleanup
branch
from
d418a93 to
9423eb5
Compare
ABenC377
previously approved these changes
Feb 12, 2024
JosephMoore25
previously approved these changes
Feb 12, 2024
jj16791
requested changes
Feb 12, 2024
dANW34V3R
reviewed
Feb 13, 2024
jj16791
previously approved these changes
Feb 14, 2024
dANW34V3R
previously approved these changes
Feb 14, 2024
…ommon variables to base class.
…rchitecture classes.
FinnWilkinson
dismissed stale reviews from jj16791, JosephMoore25, and ABenC377
via
3208192
FinnWilkinson
force-pushed
the
arch-class-cleanup
branch
from
9423eb5 to
3208192
Compare
jj16791
approved these changes
Feb 15, 2024
dANW34V3R
approved these changes
Feb 16, 2024
JosephMoore25
approved these changes
Feb 16, 2024
ABenC377
approved these changes
Feb 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves common variables into the base Architecture class, ensures functions in
.ccand.hhare in the same order, and generally makes the classes consistent with the codebase.Closes Issue #357