Merged
Conversation
jj16791
requested changes
Feb 14, 2024
23a4690 to
cfb2cfd
Compare
jj16791
requested changes
Feb 16, 2024
ABenC377
requested changes
Feb 16, 2024
Contributor
ABenC377
left a comment
There was a problem hiding this comment.
Looks good other than a comment typo
Contributor
JosephMoore25
left a comment
There was a problem hiding this comment.
Looks good, and yields impressive speedups. Happy to approve once other's comments have been handled, but nothing extra that I could find.
72e983a to
3073b03
Compare
…structions to benefit from speed of std::array, and SME instructions to have variable size of structures.
…or sme tests run using gtest filter
3073b03 to
be180a5
Compare
1 task
JosephMoore25
previously approved these changes
Feb 16, 2024
Contributor
JosephMoore25
left a comment
There was a problem hiding this comment.
Nice work. I like the change to using just operandContainer.
jj16791
requested changes
Feb 16, 2024
ABenC377
previously approved these changes
Feb 19, 2024
e0c402b
jj16791
requested changes
Feb 20, 2024
ABenC377
previously approved these changes
Feb 20, 2024
JosephMoore25
previously approved these changes
Feb 20, 2024
Contributor
JosephMoore25
left a comment
There was a problem hiding this comment.
Looks good. A shame we couldn't get isInstruction cleaner, but I'll have a think for next release.
7f75799
dANW34V3R
previously approved these changes
Feb 20, 2024
jj16791
previously approved these changes
Feb 20, 2024
JosephMoore25
previously approved these changes
Feb 20, 2024
dANW34V3R
reviewed
Feb 20, 2024
f1d2dc4
JosephMoore25
approved these changes
Feb 20, 2024
jj16791
approved these changes
Feb 20, 2024
dANW34V3R
approved these changes
Feb 20, 2024
ABenC377
approved these changes
Feb 20, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generally tidies the instruction classes and moves some common functions & member variables into the base class.
Also includes new classes in
Container.hhwhich mitigates slowdown caused by changingsourceValues_,results_,sourceRegisters_,destinationRegisters_to std::vector when SME was first supported. Said class has uses std::variant which contains std::array (used by default) and std::vector (used on call ofmakeSME()). This means most instructions can use std::array and get speed benefits, and SME instructions get the flexibility of std::vecotr (needed due to variable and large amount of operands).Closes #355
AArch64 speeds with new Constants.hh (run on M1 MacBook Pro). TX2.yaml used for tx2 binaries, a64fx.yaml for armv8.4-a(+sve) binaries, a64fx_SME.yaml for all SME binaries. SME binaries run matmul kernel for 100 iterations on square inputs.
devdevinsn-class-cleaninsn-class-clean