Update to cobra v1.5.0 and use cobra flag validations#139
Merged
Conversation
…wall Also adds helper to execute cobra command and capture its output and errors to help, for example, checking that cobra validates given args correctly.
kangasta
changed the title
Using assert.EqualError instead of assert.Errorf fixes error message validation.
kangasta
force-pushed
the
deps/cobra-1.5.0
branch
from
b1cec30 to
f8087a5
Compare
Arg validation is done before execution reaches command implementation.
This was referenced Jun 30, 2022
peknur
approved these changes
Jul 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.