Skip to content

Add database connection list and database connection cancel commands#142

Merged
kangasta merged 2 commits into
masterfrom
feat/database-connections
Jul 4, 2022
Merged

Add database connection list and database connection cancel commands#142
kangasta merged 2 commits into
masterfrom
feat/database-connections

Conversation

@kangasta
Copy link
Copy Markdown
Member

@kangasta kangasta commented Jun 30, 2022 •
edited
Loading

Depends on #139

Example output:

$ upctl database connection list pg-1x1xcpu-2gb-25gb-pl-waw1

 Process ID   State   Application name      Database   Username   Client IP   
──────────── ─────── ───────────────────── ────────── ────────── ─────────────
    3753573   idle    pgAdmin 4 - DB:db_b   db_b       upadmin    1.2.3.4 

$ upctl database connection cancel pg-1x1xcpu-2gb-25gb-pl-waw1 --pid=3753573
Cancelling connection 3753573 to database 094f3c80-b9cf-4cd6-9e2d-5754a83a2026: success          0m2s

@kangasta kangasta added the enhancement New feature or request label Jun 30, 2022
Base automatically changed from deps/cobra-1.5.0 to master July 1, 2022 08:43
@kangasta kangasta force-pushed the feat/database-connections branch 2 times, most recently from 375b287 to 2306e49 Compare July 1, 2022 10:14
@kangasta kangasta changed the title Add database connections and cancel-connection commands Add database connection list and database connection cancel commands Jul 1, 2022
@kangasta kangasta marked this pull request as ready for review July 1, 2022 10:24
@kangasta kangasta mentioned this pull request Jul 1, 2022
Merged
@kangasta kangasta force-pushed the feat/database-connections branch from 2306e49 to 53742a9 Compare July 1, 2022 11:55
@kangasta
refactor(server): move server subcommand packages under server packages
609d639 
This syncs directory structure with command structure.
@kangasta
Copy link
Copy Markdown
Member Author

kangasta commented Jul 4, 2022

Was planning to merge #143 to master, but forgot to change target. That's why those changes are in this PR.

@kangasta kangasta mentioned this pull request Jul 4, 2022
Merged
1 task
ka-myl
ka-myl approved these changes Jul 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ka-myl ka-myl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally and seems to be working fine

@kangasta kangasta merged commit 0ff2304 into master Jul 4, 2022
@kangasta kangasta deleted the feat/database-connections branch July 4, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ka-myl ka-myl ka-myl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kangasta @ka-myl