Add database start and database stop commands#144
Merged
Conversation
kangasta
force-pushed
the
feat/database-start-stop
branch
2 times, most recently
from
8e2d11c to
430d75e
Compare
kangasta
force-pushed
the
feat/database-start-stop
branch
from
430d75e to
4793430
Compare
ka-myl
reviewed
Jul 5, 2022
| ### Added | ||
| - Add `--show-ip-addresses` flag to `server list` command to optionally include IP addresses in command output. | ||
| - Add `database connection list`, and `database connection cancel` commands. | ||
| - Add `database connection list`, `database connection cancel`, `database start`, and `database stop` commands. |
Contributor
There was a problem hiding this comment.
personally I would keep each command as a separate item on the list, for me that easier to quickly parse with eyes. Not a blocker or anything ofc.
ka-myl
approved these changes
Jul 5, 2022
Contributor
ka-myl
left a comment
ka-myl
left a comment
There was a problem hiding this comment.
Code looks good. Tested locally and works as intended
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
database connection list,database connection cancel,database start, anddatabase stopcommands.