allowed trailing comma for function parameter lists and closure use lists#308
Open
allowed trailing comma for function parameter lists and closure use lists#308
Conversation
…ists
1. function foo(
$arg,
$arg2, // allowed
) { ... }
2. $foo = function () use (
$a,
$b, // allowed
) { ... };
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/trailing_comma_in_parameter_list
RFC: https://wiki.php.net/rfc/trailing_comma_in_closure_use_list
These two changes are very similar, therefore, they are combined into a single PR.
Function parameter list example:
Closure use list example:
The
GenTree::gen_listfunction is rather complicated, so a description has been added for it for all possible variants of its use.#290