Allow trailing comma for function use and parameter lists#664
Open
mkornaukhov wants to merge 5 commits intoVKCOM:masterfrom
Open
Allow trailing comma for function use and parameter lists#664mkornaukhov wants to merge 5 commits intoVKCOM:masterfrom
mkornaukhov wants to merge 5 commits intoVKCOM:masterfrom
Conversation
mkornaukhov
force-pushed
the
mkornaukhov03_trailing_comma
branch
from
1be3414 to
6c012c8
Compare
Contributor
|
Hi! I would suggest adding the tests.
Basically, this feature should work when it works in PHP and fail to compile when it's not a valid syntax for PHP. You may look at the PHP pull request for an inspiration. It probably includes some tests. See the docs for more info about contributing (how to run tests, etc.) Or you can ask the questions here. |
mkornaukhov
force-pushed
the
mkornaukhov03_trailing_comma
branch
from
6c012c8 to
1f5cfa1
Compare
Contributor
Author
|
Please check |
mkornaukhov
force-pushed
the
mkornaukhov03_trailing_comma
branch
from
a7fe9c3 to
f452192
Compare
mkornaukhov
requested review from
quasilyte and
tolk-vm
and removed request for
tolk-vm
mkornaukhov
force-pushed
the
mkornaukhov03_trailing_comma
branch
3 times, most recently
from
f5937ec to
8f78498
Compare
mkornaukhov
force-pushed
the
mkornaukhov03_trailing_comma
branch
from
8f78498 to
19abded
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support PHP8 feature.
Main issue: #290
Previous attempt: #308
I didn't rebase because of merge conflict.