feat: avoid auto-installing when already installed

[alestiago]

Status

READY

Description

Resolves #56

Should be merged after #73

Changes:

• Adds installs into CompletionConfiguration
• Check if already installed before auto-installing
• Renamed typedef Uinstalls to ShellCommandsMap since it is now used

Type of Change

• ✨ New feature (non-breaking change which adds functionality)
• 🛠️ Bug fix (non-breaking change which fixes an issue)
• ❌ Breaking change (fix or feature that would cause existing functionality to change)
• 🧹 Code refactor
• ✅ Build configuration change
• 📝 Documentation
• 🗑️ Chore

[renancaraujo]

I don't get we have to keep a map of all commands. If we have this lib installed on a cli, other installations should not concern this routine. In other words, this algorithm will never use more the one element in these collections, especially "installs"

[renancaraujo]

Why is this "installs" collection necessary?

[alestiago]

I'm going to illustrate the necessity of the installs collection with an example and the mathematical interpreation. After reading them, do you have another approach in mind?

Note that as planned off-github, installs and uninstalls are stored on a single "global" configuration file (~/.dart-cli-completion/config.json).

---

Example

1. User uses very_good command in ZSH and it gets auto-installed, the installs collection will go from being empty to:

{
  SystemShell.zsh: {"very_good"}
}

2. User uses dart_frog command in ZSH and it gets auto-installed, the installs collection will now be:

{
  SystemShell.zsh: {"very_good", "dart_frog"}
}

3. User uses very_good command in in Bash and it gets auto-installed, the installs collection will now be:

{
  SystemShell.zsh: {"very_good", "dart_frog"},
  SystemShell.bash: {"very_good"},
}

5. User uses very_good command in Zsh and it does not get auto-installed since we know it it already installed.

---

Mathematical interpretation

The $installs$ set (let it be denoted with $I$) collection is mutually exclusive to the $uninstalls$ set (let it be denoted with $U$); as shown in the Venn Diagram below. It is instructive to know that $I \cup U \neq \text{all commands}$, hence a single collection is not enough. It follows that if and only if auto-install is enabled on all commands: $I \cup U = \text{all commands used so far after cli completion was installed}$.