Skip to content

feat: avoid autoinstalling manually uninstalled commands #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alestiago merged 30 commits into from
May 23, 2023
Merged

feat: avoid autoinstalling manually uninstalled commands #73

alestiago merged 30 commits into from
May 23, 2023

Conversation

@alestiago
Copy link
Contributor

@alestiago alestiago commented May 18, 2023 •
edited
Loading

Status

READY

Description

Closes #57

Changes:

  • Adds rootCommand to uninstall list when uninstalled
  • Removes rootCommand from uninstall list when installed
  • Checks if rootCommand is uninstalled before auto install

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

alestiago added 19 commits May 18, 2023 12:11
@alestiago alestiago marked this pull request as ready for review May 22, 2023 17:00
@alestiago alestiago self-assigned this May 22, 2023
@alestiago alestiago mentioned this pull request May 23, 2023
Merged
7 tasks
erickzanardo
erickzanardo previously approved these changes May 23, 2023
View reviewed changes
renancaraujo
renancaraujo reviewed May 23, 2023
View reviewed changes
renancaraujo
renancaraujo approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@renancaraujo renancaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏾

@alestiago alestiago merged commit 527db4c into main May 23, 2023
@alestiago alestiago deleted the feat/avoid-autoinstalling-uninstalls branch May 23, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erickzanardo erickzanardo erickzanardo approved these changes

@felangel felangel Awaiting requested review from felangel

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

+1 more reviewer

@renancaraujo renancaraujo renancaraujo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alestiago alestiago

Labels

None yet

Projects

VGV Open Source 🦄 🧙🌟
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: Add uninstall behavior

4 participants

@alestiago @erickzanardo @renancaraujo