-
Notifications
You must be signed in to change notification settings - Fork 10
LOG-6789: Missing region error when using AWS credentials file #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOG-6789: Missing region error when using AWS credentials file #197
Conversation
|
@cahartma: This pull request references LOG-6789 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@cahartma: This pull request references LOG-6789 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
70812b1 to
5bab2af
Compare
5bab2af to
486d2e2
Compare
jcantrill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm other then one comment
|
@cahartma: This pull request references LOG-6789 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
486d2e2 to
d430bf1
Compare
|
@cahartma: This pull request references LOG-6789 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Upstream changes have been approved and merged into master: vectordotdev#22831 |
|
/hold |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cahartma, jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
|
/lgtm |
Quick fix to add region to the credentials file auth module in vector. This now allows both
auth.regionandauth.profileto be set. We will need to use profile if we build the configMap as one credentials file for all outputs (and specify the profiles).This change is submitted upstream as vectordotdev#22831, but the file is slightly different since we are on v0.37. We have a path forward regardless.
cc @jcantrill @vparfonov @Clee2691 @syedriko