Skip to content

Conversation

@cahartma
Copy link

@cahartma cahartma commented Apr 4, 2025

Quick fix to add region to the credentials file auth module in vector. This now allows both auth.region and auth.profile to be set. We will need to use profile if we build the configMap as one credentials file for all outputs (and specify the profiles).

This change is submitted upstream as vectordotdev#22831, but the file is slightly different since we are on v0.37. We have a path forward regardless.

cc @jcantrill @vparfonov @Clee2691 @syedriko

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 4, 2025

@cahartma: This pull request references LOG-6789 which is a valid jira issue.

Details

In response to this:

Quick fix to add region to the credentials file auth module in vector. This now allows both auth.region and auth.profile to be set. We will need to use profile if we build the configMap as one credentials file for all outputs (and specify the profiles).

This change is not submitted upstream yet, since we are on a relatively old version of vector. I wanted to get this in first so we have a path forward regardless.

The other file changes were necessary for cargo to build successfully. I haven't tested the tls code exactly, but the tests pass. Not sure if these are necessary or a result of local cargo/vendor issues.

cc @jcantrill @vparfonov @Clee2691 @syedriko

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 4, 2025

@cahartma: This pull request references LOG-6789 which is a valid jira issue.

Details

In response to this:

Quick fix to add region to the credentials file auth module in vector. This now allows both auth.region and auth.profile to be set. We will need to use profile if we build the configMap as one credentials file for all outputs (and specify the profiles).

This change is not submitted upstream yet, since we are on a relatively old version of vector. I wanted to get this in first so we have a path forward regardless.

The other file changes were necessary for cargo to build successfully. I haven't tested the tls code exactly, but the tests pass. Not sure if these are necessary or a result of local cargo/vendor issues.

cc @jcantrill @vparfonov @Clee2691 @syedriko

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Clee2691
Copy link

Clee2691 commented Apr 4, 2025

/lgtm

Copy link
Member

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other then one comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 8, 2025

@cahartma: This pull request references LOG-6789 which is a valid jira issue.

Details

In response to this:

Quick fix to add region to the credentials file auth module in vector. This now allows both auth.region and auth.profile to be set. We will need to use profile if we build the configMap as one credentials file for all outputs (and specify the profiles).

This change is submitted upstream as vectordotdev#22831, but the file is slightly different since we are on v0.37. We have a path forward regardless.

The other file changes were necessary for cargo to build successfully. I haven't tested the tls code exactly, but the tests pass. Not sure if these are necessary or a result of local cargo/vendor issues.

cc @jcantrill @vparfonov @Clee2691 @syedriko

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cahartma cahartma force-pushed the LOG-6789-v37.1-aws-auth-fix branch from 486d2e2 to d430bf1 Compare April 8, 2025 16:40
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 8, 2025

@cahartma: This pull request references LOG-6789 which is a valid jira issue.

Details

In response to this:

Quick fix to add region to the credentials file auth module in vector. This now allows both auth.region and auth.profile to be set. We will need to use profile if we build the configMap as one credentials file for all outputs (and specify the profiles).

This change is submitted upstream as vectordotdev#22831, but the file is slightly different since we are on v0.37. We have a path forward regardless.

cc @jcantrill @vparfonov @Clee2691 @syedriko

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cahartma
Copy link
Author

cahartma commented Apr 9, 2025

Upstream changes have been approved and merged into master: vectordotdev#22831

@jcantrill
Copy link
Member

/hold

@jcantrill
Copy link
Member

/approve

@openshift-ci
Copy link

openshift-ci bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cahartma, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cahartma
Copy link
Author

/unhold

@Clee2691
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 22, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit e14651a into ViaQ:v0.37.1-rh Apr 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants