NO JIRA: Updating vendor directory missing files and quick fix for cargo check #198
Conversation
cahartma
requested review from
jcantrill and
vparfonov
and removed request for
alanconway
| } | ||
| } | ||
|
|
||
| #[derive(Clone)] |
There was a problem hiding this comment.
this changes also related to the cargo check?
There was a problem hiding this comment.
Yes, this fails for me every time. tls connected trait was not added correctly at implementation.
|
|
||
| const fn should_encode_as_binary(&self) -> bool { | ||
| use vector_lib::codecs::encoding::Serializer::{ | ||
| Avro, Csv, Gelf, Json, Logfmt, Native, NativeJson, Protobuf, RawMessage, Text, |
There was a problem hiding this comment.
Is this changes also related to the cargo check?
There was a problem hiding this comment.
Yes cargo check should fail when you run it without the changes, as syslog was not initially added to the implemented interfaces.
|
/lgtm |
|
/hold for z-stream code freeze |
|
@cahartma do we need to update our CI to embrace these test changes? |
| # Jetbrains | ||
| .idea/ | ||
|
|
||
| !vendor/ |
There was a problem hiding this comment.
Why do we now need to vendor dependencies? Is it absolutely necessary? These don't look security critical but do we have a mechanism to ensure they get upgraded as either the vector version gets updated or we discover security flaws?
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cahartma, jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
3 participants
Updated files to ensure
cargo checkruns successfully. Two vendor packages were updated to include files from the checksum (same package but different versions). One fix for tls file, adding the missing 'Connected' trait.In addition to being able to successfully run
cargo check --offline:Now, we should be able to build dev and run all upstream unit tests:
cc: @jcantrill @Clee2691 @vparfonov