feat: Adding '---' to the beginning of yaml files generated by cli#48
Merged
Conversation
Christakou
commented
Mar 28, 2023
|
|
||
| def __enter__(self): | ||
| return Mock(), None | ||
| return Mock() |
Contributor
Author
There was a problem hiding this comment.
This was returning a tuple, which has not '.write' method, and was messing up the tests.
Changed it to return a mock object, all tests continued to run succesfully.
Christakou
added
bug
Christos-Hadjinikolis
approved these changes
Mar 28, 2023
Collaborator
Christos-Hadjinikolis
left a comment
Christos-Hadjinikolis
left a comment
There was a problem hiding this comment.
Love how consistent you are !! ❤️
joloppo
added a commit
that referenced
this pull request
Jul 11, 2023
* feat: Adding '---' to the beginning of yaml files generated by cli (#48) * feat: Adding '---' to the beginning of yaml files generated by cli * feat: renaming variable * feat: add resource migration script * feat: Add migration cli * feat: add schema migration script * feat: Working migration command for schemas * Add capability to convert both schemas and resources --------- Co-authored-by: Christiano <41486691+Christakou@users.noreply.github.com> Co-authored-by: Artur Krochin <artur.krochin@vortexa.com>
joloppo
added a commit
that referenced
this pull request
Jul 19, 2023
* feat: Adding '---' to the beginning of yaml files generated by cli (#48) * feat: Adding '---' to the beginning of yaml files generated by cli * feat: renaming variable * feat: add resource migration script * feat: Add migration cli * feat: add schema migration script * feat: Working migration command for schemas * Add capability to convert both schemas and resources * Add uhura & serde for file resources * Correct typehint * Change hdf extension * Add uhura tests & fix missing test_path attributes * Add uhura for s3 resources (& tests) * Fix migration script confirm prompt * Add injections and checking in all relevant places * Add postgres + uhura resource * Add missing check_injections to postgres * Correct postgres cache key and test * Add kafka + uhura resource * Remove dead code * Remove dead code * Add and improve tests * Fix test writing to files * Remove dead code * Format code * Add kafka inject tests * Format code * Add tests for serde and change serde init signature * Add resource test_path inject test * Update migration scripts to work for new uhura based resources * Add brackets --------- Co-authored-by: Christiano <41486691+Christakou@users.noreply.github.com> Co-authored-by: Artur Krochin <artur.krochin@vortexa.com>
joloppo
added a commit
that referenced
this pull request
Jul 19, 2023
* feat: Adding '---' to the beginning of yaml files generated by cli (#48) * feat: Adding '---' to the beginning of yaml files generated by cli * feat: renaming variable * feat: add resource migration script * feat: Add migration cli * feat: add schema migration script * feat: Working migration command for schemas * Add capability to convert both schemas and resources * feat: add support for has_no_nulls validation * feat: add support for is_in validator * feat: add support for uniqueness validator * feat: add support for greater than validation * fix: fix issue with empty normalized col names * feat: add validator for greater than or equals * feat: add validator for is between * fix: remove scaffolding * fix: optimise imports * feat: add note about custom validations * feat: Add demo files * feat: Correct demo files * feat: Add less than and less equals to schema migration cli * feat: Add migration schema match_all warning --------- Co-authored-by: Christiano <41486691+Christakou@users.noreply.github.com> Co-authored-by: Artur Krochin <artur.krochin@vortexa.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Current CLI tool generated schemas dont adhere to the yamllint convention of starting the file with '---'
This fixes it.
Key Changes
Added a line to write '---' at the beginning of yaml files
Tested locally