Skip to content

feat: Add schema validations to migrations#58

Merged
joloppo merged 22 commits into
v5from
v4to5-migration
Jul 19, 2023
Merged

feat: Add schema validations to migrations#58
joloppo merged 22 commits into
v5from
v4to5-migration

Conversation

@joloppo
Copy link
Copy Markdown
Contributor

@joloppo joloppo commented Jul 19, 2023

No description provided.

@joloppo
Copy link
Copy Markdown
Contributor Author

joloppo commented Jul 19, 2023

@arturk-vortexa I've added some demo files. You can test them by running

python -m dynamicio.v5_migration convert-everything demo/migrations/v4_schema.yaml demo/migrations/v5_schema.py

Seems to be working correctly for the most part. The lower than things are not working. Also, is_in and match_all is something we'll have to do custom (see screenshot). (Also see v4 readme.) It's all a bit backwards in v4.
image

@joloppo joloppo marked this pull request as ready for review July 19, 2023 14:51
@joloppo joloppo requested a review from Christakou July 19, 2023 16:04
Copy link
Copy Markdown
Contributor

@Christakou Christakou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joloppo joloppo merged commit 3cba135 into v5 Jul 19, 2023
@arturk-vortexa arturk-vortexa mentioned this pull request Aug 4, 2023
@joloppo joloppo deleted the v4to5-migration branch September 20, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants