Skip to content

Conversation

@Aaron-Detre
Copy link
Contributor

@Aaron-Detre Aaron-Detre commented Feb 11, 2025

Changes

  • Added method forBerkeleyEndpoint() to CRaterRequest interface which checks for "berkeley_" prefix.
  • Exposed cRaterUrl setter in CRaterRequest interface to enable new method setRequestCRaterUrl in CRaterService to set the cRaterUrl for any implementation of CRaterRequest rather than writing duplicate code for each implementation of CRaterRequest.
  • Added tests to make sure that getScoringRequest() and getVerificationRequest() in CRaterService are trying to send HTTP requests to the Berkeley endpoint rather than the ETS endpoint when the request's itemId has the "berkeley_" prefix.

Test

  • Make sure scoring and verification requests without the "berkeley_" prefix in the itemId are still sent to the ETS endpoint.
    • The dialog guidance should still work as normal since none of the current itemId's should have the "berkeley_" prefix.
  • Make sure scoring and verification requests with the "berkeley_" prefix in the itemId are sent to the Berkeley endpoint once it exists.

Closes #286

@Aaron-Detre Aaron-Detre self-assigned this Feb 11, 2025
@Aaron-Detre Aaron-Detre added the enhancement New feature or request label Feb 11, 2025
@Aaron-Detre Aaron-Detre marked this pull request as ready for review February 11, 2025 23:58
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start.

We'll also need to allow WISE admins to specify values for "berkeley_cRater_client_id" and "berkeley_cRater_password" keys. These will be used to authorize access to the Berkeley endpoint.

Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hirokiterashima hirokiterashima merged commit e7b5de1 into develop Mar 8, 2025
3 checks passed
@hirokiterashima hirokiterashima deleted the issue-286-allow-requests-to-berkeley-endpoint branch March 8, 2025 00:51
@hirokiterashima
Copy link
Member

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(CRater): Allow requests to be sent to Berkeley endpoint

3 participants