v4: custom session sig setter #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himanshuchawla009
changed the title
ieow
reviewed
Nov 26, 2024
src/mpcCoreKit.ts
Outdated
|
|
||
| this.updateState({ | ||
| postBoxKey, | ||
| postboxKeyNodeIndexes: loginResponse.nodesData?.nodeIndexes, |
Contributor
There was a problem hiding this comment.
do we need to take nodeIndexes in to consideration?
Member
Author
There was a problem hiding this comment.
yes, i need it so that passkey link api should know which nodes contains shares of the postbox key
Demo/passskey plugin demo
ieow
reviewed
Dec 4, 2024
package/package.json
Outdated
| @@ -0,0 +1,117 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
Is this package folder's files needed?
is it created by error?
Member
Author
There was a problem hiding this comment.
ah, yeah its by mistake, i will remove it
import sfa key
ieow
approved these changes
Dec 16, 2024
Contributor
|
eh guys @himanshuchawla009 @ieow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.