MinifyImportsAndExports: Minify the memory and table as well. #3089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Sep 1, 2020
sbc100
approved these changes
Sep 2, 2020
| } | ||
| if (module->table.exists) { | ||
| processImport(&module->table); | ||
| } |
Member
There was a problem hiding this comment.
Could we just use iterImportedMemories and iterImportedTables?
Or better still add an iterImports and just use that?
Member
Author
There was a problem hiding this comment.
Ah, good idea for iterImports, that's much nicer. Added now.
(edit: and yes, I forgot about iterImportedMemories and iterImportedTables)
kripken
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Sep 2, 2020
Code size improvements + stack improvements are inbound, WebAssembly/binaryen#3089 WebAssembly/binaryen#3091
kripken
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Sep 3, 2020
Code size improvements are from WebAssembly/binaryen#3089 which lets us now minify the name of the memory and the table among the wasm imports and exports. Reverts the disablings in #12099, #12100 (except for the safe stack one, which requires more fixes in a subsequent PR).
MaxGraey
reviewed
Sep 8, 2020
| std::map<Name, Name> newToOld; | ||
| auto process = [&](Name& name) { | ||
| // do not minifiy special imports, they must always exist | ||
| if (name == MEMORY_BASE || name == TABLE_BASE || name == STACK_POINTER) { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Member
Author
There was a problem hiding this comment.
Yes, the special stack pointer import is relevant only for dynamic linking, but as mentioned earlier, we don't run this pass in that case anyhow.
sbc100
added a commit
that referenced
this pull request
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were careful not to minify those, as well as the stack pointer, which
makes sense in dynamic linking. But we don't run this pass in dynamic linking
anyhow - we need the proper names of symbols in that case. So this was
not helping us, and was just a leftover from an early state.
This both a useful optimization and also important for #3043,
as the wasm backend exports the table as
__indirect_function_table- a muchlonger name than emscripten's
table. So just changing to that would regresscode size on small projects. Once we land this, the name won't matter as it will
be minified anyhow.
This will break some tests on the roller as it improves code size beyond
current expectations, so it will require a double-roll or a temporary test
disabling.