MinifyImportsAndExports: Minify the memory and table as well.

src/ir/module-utils.h

@@ -229,6 +229,14 @@ template<typename T> inline void iterDefinedEvents(Module& wasm, T visitor) {
   }
 }
 
+template<typename T> inline void iterImports(Module& wasm, T visitor) {
+  iterImportedMemories(wasm, visitor);
+  iterImportedTables(wasm, visitor);
+  iterImportedGlobals(wasm, visitor);
+  iterImportedFunctions(wasm, visitor);
+  iterImportedEvents(wasm, visitor);
+}
+
 // Helper class for performing an operation on all the functions in the module,
 // in parallel, with an Info object for each one that can contain results of
 // some computation that the operation performs.

src/passes/MinifyImportsAndExports.cpp

@@ -148,10 +148,6 @@ struct MinifyImportsAndExports : public Pass {
     std::map<Name, Name> oldToNew;
     std::map<Name, Name> newToOld;
     auto process = [&](Name& name) {
-      // do not minifiy special imports, they must always exist
-      if (name == MEMORY_BASE || name == TABLE_BASE || name == STACK_POINTER) {
-        return;
-      }
       auto iter = oldToNew.find(name);
       if (iter == oldToNew.end()) {
         auto newName = names.getName(soFar++);
@@ -162,7 +158,7 @@ struct MinifyImportsAndExports : public Pass {
         name = iter->second;
       }
     };
-    auto processImport = [&](Importable* curr) {
+    ModuleUtils::iterImports(*module, [&](Importable* curr) {
       // Minify all import base names if we are importing modules (which means
       // we will minify all modules names, so we are not being careful).
       // Otherwise, assume we just want to minify "normal" imports like env
@@ -171,10 +167,7 @@ struct MinifyImportsAndExports : public Pass {
           curr->module.startsWith("wasi_")) {
         process(curr->base);
       }
-    };
-    ModuleUtils::iterImportedGlobals(*module, processImport);
-    ModuleUtils::iterImportedFunctions(*module, processImport);
-    ModuleUtils::iterImportedEvents(*module, processImport);
+    });
 
     if (minifyExports) {
       // Minify the exported names.
@@ -201,18 +194,13 @@ struct MinifyImportsAndExports : public Pass {
 #ifndef NDEBUG
     std::set<Name> seenImports;
 #endif
-    auto processImport = [&](Importable* curr) {
+    ModuleUtils::iterImports(*module, [&](Importable* curr) {
       curr->module = SINGLETON_MODULE_NAME;
 #ifndef NDEBUG
       assert(seenImports.count(curr->base) == 0);
       seenImports.insert(curr->base);
 #endif
-    };
-    ModuleUtils::iterImportedGlobals(*module, processImport);
-    ModuleUtils::iterImportedFunctions(*module, processImport);
-    ModuleUtils::iterImportedEvents(*module, processImport);
-    ModuleUtils::iterImportedMemories(*module, processImport);
-    ModuleUtils::iterImportedTables(*module, processImport);
+    });
   }
 };
 

test/passes/minify-imports-and-exports-and-modules.txt

@@ -1,13 +1,15 @@
-longname1 => a
-longname2 => b
-longname3 => c
-longname4 => d
+memory => a
+table => b
+longname1 => c
+longname2 => d
+longname3 => e
+longname4 => f
 (module
  (type $none_=>_none (func))
- (import "a" "memory" (memory $0 256 256))
- (import "a" "table" (table $0 4 funcref))
- (import "a" "a" (func $internal1))
- (import "a" "b" (func $internal2))
- (import "a" "c" (func $internal3))
- (import "a" "d" (func $internal4))
+ (import "a" "a" (memory $0 256 256))
+ (import "a" "b" (table $0 4 funcref))
+ (import "a" "c" (func $internal1))
+ (import "a" "d" (func $internal2))
+ (import "a" "e" (func $internal3))
+ (import "a" "f" (func $internal4))
 )