wasm2js: override incoming memory's grow method #3185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow for the completely removal of __growWasmMemory as a followup. We currently unconditionaly generate this function in generateMemoryGrowthFunction. See #31803180
sbc100
force-pushed
the
patch_memory_grow
branch
from
31c8981 to
7be70c3
Compare
sbc100
changed the title
sbc100
force-pushed
the
patch_memory_grow
branch
from
7be70c3 to
ecf3216
Compare
sbc100
force-pushed
the
patch_memory_grow
branch
from
ecf3216 to
1b7afcc
Compare
kripken
approved these changes
Oct 1, 2020
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
I think this is good, but you're making the JS output even more interesting, so might be worth running emscripten tests before landing, to avoid a minification surprise...
Member
Author
|
Yeah I've been ruing wasm2js0 wasm2 and other pretty consistently. |
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Oct 1, 2020
This is no longer needed since wasm2js will not inject a grow function into the memory that it imports (if needed). See: WebAssembly/binaryen#3185
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Oct 1, 2020
This is no longer needed since wasm2js will not inject a grow function into the memory that it imports (if needed). See: WebAssembly/binaryen#3185
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Oct 1, 2020
This is no longer needed since wasm2js will not inject a grow function into the memory that it imports (if needed). See: WebAssembly/binaryen#3185
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Oct 1, 2020
This is no longer needed since wasm2js will not inject a grow function into the memory that it imports (if needed). See: WebAssembly/binaryen#3185
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Oct 1, 2020
This is no longer needed since wasm2js will not inject a grow function into the memory that it imports (if needed). See: WebAssembly/binaryen#3185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow for the completely removal of
__growWasmMemoryas a followup. We currentlyunconditionally generate this function in
generateMemoryGrowthFunction.See #3180