Remove references to __growWasmMemory #12391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Oct 1, 2020
This depends on emscripten-core/emscripten#12391
sbc100
force-pushed
the
remove_grow_memory_references
branch
from
b3f36fc to
9ea5826
Compare
sbc100
force-pushed
the
remove_grow_memory_references
branch
from
9ea5826 to
2d0594b
Compare
kripken
approved these changes
Oct 1, 2020
This is no longer needed since wasm2js will not inject a grow function into the memory that it imports (if needed). See: WebAssembly/binaryen#3185
sbc100
force-pushed
the
remove_grow_memory_references
branch
from
2d0594b to
15fb03e
Compare
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Oct 1, 2020
This depends on emscripten-core/emscripten#12391
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is no longer needed since wasm2js will not
inject a grow function into the memory that it
imports (if needed).
See: WebAssembly/binaryen#3185