Conversation
dcodeIO
approved these changes
Jan 14, 2021
Contributor
dcodeIO
left a comment
dcodeIO
left a comment
There was a problem hiding this comment.
Makes it more clear to me :)
aheejin
approved these changes
Jan 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #3486, I wonder if it isn't a little more clear this way,
which avoids the confusion of
usedElementsbeing changedwhile we are using it?
In general I think it's best to only use
usedElementsin the mostinternal methods, and to call
size()otherwise. But I don't feelstrongly.