Skip to content

Avoid usedElements around code that modifies that value #3488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 1 commit into from
Jan 14, 2021
Merged

Avoid usedElements around code that modifies that value #3488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/mixed_arena.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,21 +368,21 @@ template<typename SubType, typename T> class ArenaVectorBase {
// C-API

void insertAt(size_t index, T item) {
assert(index <= usedElements); // appending is ok
resize(usedElements + 1);
for (auto i = usedElements - 1; i > index; --i) {
assert(index <= size()); // appending is ok
resize(size() + 1);
for (auto i = size() - 1; i > index; --i) {
data[i] = data[i - 1];
}
data[index] = item;
}

T removeAt(size_t index) {
assert(index < usedElements);
assert(index < size());
auto item = data[index];
for (auto i = index; i < usedElements - 1; ++i) {
for (auto i = index; i < size() - 1; ++i) {
data[i] = data[i + 1];
}
resize(usedElements - 1);
resize(size() - 1);
return item;
}
};
Expand Down