[EH] Replace event with tag#3937
Conversation
We recently decided to change 'event' to 'tag', and to 'event section' to 'tag section', out of the rationale that the section contains a generalized tag that references a type, which may be used for something other than exceptions, and the name 'event' can be confusing in the web context. See - WebAssembly/exception-handling#159 (comment) - WebAssembly/exception-handling#161
|
Don't know what's going on with clang-tidy... Anyone has a clue? https://github.com/WebAssembly/binaryen/pull/3937/checks?check_run_id=2844692867 |
|
No idea... that started happening in every PR that modifies the delegations headers. It's a false positive, but I don't know how to ignore it... |
|
We explicitly I haven't seen any configuration options in clang-tidy that could fix this, but if we wanted to get clang-tidy working correctly we could downgrade these |
|
Uploaded #3941 to fix the clang-tidy issue. If that lands, I can rebase this PR onto that. |
We recently decided to change 'event' to 'tag', and 'event section' to
'tag section', out of the rationale that the section contains a
generalized tag that references a type, which may be used for something
other than exceptions, and the name 'event' can be confusing in the web
context.
See