Rename wasm-delegations[-fields].h to def files (NFC)#3941
Merged
aheejin merged 2 commits intoWebAssembly:mainfrom Jun 18, 2021
Merged
Rename wasm-delegations[-fields].h to def files (NFC)#3941aheejin merged 2 commits intoWebAssembly:mainfrom
aheejin merged 2 commits intoWebAssembly:mainfrom
Conversation
These files are special in that they use define symbols that are not defined within those files or other files included in those files; they are supposed to be defined in source files that include these headers. This has caused clang-tidy to fail every time these files have changed because they are not compilable per se. This PR solves the problem by changing their extension to `def`, which is also used in LLVM codebase. LLVM has dozens of files like this whose extension is `def`, which makes this not checked by clang-tidy.
tlively
approved these changes
Jun 18, 2021
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
Good thinking! This is a much better solution than what I was thinking of :)
Member
Author
|
@tlively Out of curiosity, what was the solution you were thinking of? |
Member
|
The workarounds I mentioned in #3937 (comment). Downgrading the errors to warnings would have been an unfortunate loss of functionality and avoiding the errors in the special case where none of the macros are defined would have been unnecessarily complicated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These files are special in that they use define symbols that are not
defined within those files or other files included in those files; they
are supposed to be defined in source files that include these headers.
This has caused clang-tidy to fail every time these files have changed
because they are not compilable per se.
This PR solves the problem by changing their extension to
def, whichis also used in LLVM codebase. LLVM has dozens of files like this whose
extension is
def, which makes these not checked by clang-tidy.