Merged
Conversation
Member
|
Looks good, but could you also s/memory_size/current_memory/ in the rest of the design repo (there are a few)? |
Member
Author
|
Done, but I had to do a bit of rewording to make it fit. |
Member
|
lgtm, thanks |
Member
|
lgtm This reminds me (not for this PR): didn't we discuss getting rid of this operator because of the race it may have (get current_memory and it's potentially already been changed by another thread)? |
Member
Author
|
Merging with LGTMs and no objection |
|
Shall we change BinaryEncoding.md with this new fix? |
lukewagner
pushed a commit
that referenced
this pull request
Apr 28, 2016
Add current_memory operator
lukewagner
added a commit
that referenced
this pull request
Apr 29, 2016
* Merge pull request #648 from WebAssembly/current_memory Add current_memory operator * Reorder section size field (#639) * Prettify section names (#638) * Extensible encoding of function signatures (#640) * Prettify section names * Restructure encoding of function signatures * Revert "[Binary 11] Update the version number to 0xB." * Leave index space for growing the number of base types * Comments addressed * clarify how export/import names convert to JS strings (#569) (#573) * When embedded in the web, clarify how export/import names convert to JS strings (#569) * Fixes suggested by @jf * Address more feedback Added a link to http://monsur.hossa.in/2012/07/20/utf-8-in-javascript.html. Simplified the decoding algorithm thanks to Luke's feedback. * Access to proprietary APIs apart from HTML5 (#656) * comments * Merge pull request #641 from WebAssembly/postorder_opcodes Postorder opcodes * fix some text that seems to be in the wrong order (#670) * Clarify that br_table has a branch argument (#664) * Add explicit argument counts (#672) * Add explicit arities * Rename * Replace uint8 with varint7 in form field (#662) This needs to be variable-length.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #629, the
memory_sizeoperator (which actually was missing from AstSemantics) is the last one not counting memory in page units. This PR species that, and also renames it tocurrent_memory(as suggested here).