[test] Check that memory is exported/imported with correct min limit after grow#1293
Merged
rossberg merged 1 commit intoWebAssembly:masterfrom Apr 12, 2021
Merged
Conversation
Author
|
@rossberg Is this going to be merged? |
gumb0
added a commit
to wasmx/wasm-spec
that referenced
this pull request
Apr 14, 2021
gumb0
added a commit
to wasmx/wasm-spec
that referenced
this pull request
Apr 15, 2021
gumb0
added a commit
to wasmx/wasm-spec
that referenced
this pull request
Apr 19, 2021
gumb0
added a commit
to wasmx/wasm-spec
that referenced
this pull request
Apr 20, 2021
gumb0
added a commit
to wasmx/wasm-spec
that referenced
this pull request
Apr 20, 2021
kateinoigakukun
added a commit
to kateinoigakukun/wasminspect
that referenced
this pull request
Nov 4, 2021
gumb0
added a commit
to wasmx/wasm-spec
that referenced
this pull request
Jun 22, 2022
gumb0
added a commit
to wasmx/wasm-spec
that referenced
this pull request
Jun 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made this to check my understanding of the external memory definition in the spec:
IIUC it requires imported memory to have
minlimit equal to it's currently allocated size, which means it can be updated after grow, and that has implications on matching this memory limits against import definition in another module.The test basically creates a module with
(memory 1), grows it to 2 pages, then tries to import it into a module with(memory 2).Then repeats it another time for the memory that is both imported and exported.
(It fails on WABT.)