Enforce updated lower limit of exported memory after grow#755
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #755 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 85 85
Lines 12978 13010 +32
=======================================
+ Hits 12864 12896 +32
Misses 114 114
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
force-pushed
the
export-grown-memory
branch
from
7bb4e26 to
21ce9ea
Compare
Member
|
I think we should not merge this until the spectest is merged. |
gumb0
force-pushed
the
export-grown-memory
branch
from
21ce9ea to
6932008
Compare
gumb0
force-pushed
the
export-grown-memory
branch
2 times, most recently
from
8db59ab to
cae8c11
Compare
gumb0
changed the title
gumb0
force-pushed
the
imported-limits-check
branch
from
f34043f to
f8811f9
Compare
gumb0
force-pushed
the
export-grown-memory
branch
from
cae8c11 to
b88e33b
Compare
gumb0
force-pushed
the
imported-limits-check
branch
from
f8811f9 to
b39277a
Compare
gumb0
force-pushed
the
imported-limits-check
branch
from
b39277a to
52defb1
Compare
gumb0
force-pushed
the
export-grown-memory
branch
from
b88e33b to
aebc2ed
Compare
Member
|
This was merged last April. |
chfast
approved these changes
Nov 22, 2021
Collaborator
Author
|
Related spec tests are backported to Fizzy spectests in wasmx/wasm-spec#3 |
gumb0
force-pushed
the
export-grown-memory
branch
from
aebc2ed to
ed9f106
Compare
axic
approved these changes
May 20, 2022
chfast
approved these changes
May 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the case from WebAssembly/spec#1293 (and depends on it being merged)
find_exported_memory(Note: this approach will not work if
find_exported_memorywill be called before executingmemory.growagain)