Backport new tests from WebAssembly/spec master#3
Backport new tests from WebAssembly/spec master#3gumb0 wants to merge 5 commits intow3c-1.0-tests-backportedfrom
Conversation
6317ceb to
dfd408f
Compare
| "\0b" ;; end | ||
| ) | ||
| "zero flag expected" | ||
| "zero byte expected" |
There was a problem hiding this comment.
Fizzy spectest runner uses these strings only for logging, so this is not much useful for us, but also doesn't hurt, so I included such changes to be closer to upstream and make future backporting potentially easier.
| ;; Invalid bounds for data | ||
|
|
||
| (assert_unlinkable | ||
| (assert_trap |
There was a problem hiding this comment.
Not sure why this is changed (maybe related to some new rules about out of bounds during instantiation https://github.com/WebAssembly/spec/blob/f607ec9a776a9e3425639f3cbe9b2d96bdc16b60/test/core/linking.wast#L395)
For us the change is optional, but if we accept it, requires the change in spectest runner (see wasmx/fizzy#750)
|
Some more comments about backporting WebAssembly#1287
|
59cd51e to
3833a3d
Compare
3833a3d to
438a8d3
Compare
|
It looks too complicated to try to backport WebAssembly#1287 commit's changes applicable to 1.0, so we'll be skipping it (and other post-1.0-related test commits). |
No description provided.