Skip to content

Backport new tests from WebAssembly/spec master#3

Closed
gumb0 wants to merge 5 commits intow3c-1.0-tests-backportedfrom
w3c-1.0-tests-backported-fizzy-0.8.0
Closed

Backport new tests from WebAssembly/spec master#3
gumb0 wants to merge 5 commits intow3c-1.0-tests-backportedfrom
w3c-1.0-tests-backported-fizzy-0.8.0

Conversation

@gumb0
Copy link
Collaborator

@gumb0 gumb0 commented Mar 4, 2021

No description provided.

@gumb0 gumb0 changed the base branch from master to w3c-1.0-tests-backported March 4, 2021 16:59
@gumb0 gumb0 force-pushed the w3c-1.0-tests-backported-fizzy-0.8.0 branch 6 times, most recently from 6317ceb to dfd408f Compare April 15, 2021 09:00
"\0b" ;; end
)
"zero flag expected"
"zero byte expected"
Copy link
Collaborator Author

@gumb0 gumb0 Apr 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fizzy spectest runner uses these strings only for logging, so this is not much useful for us, but also doesn't hurt, so I included such changes to be closer to upstream and make future backporting potentially easier.

;; Invalid bounds for data

(assert_unlinkable
(assert_trap
Copy link
Collaborator Author

@gumb0 gumb0 Apr 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is changed (maybe related to some new rules about out of bounds during instantiation https://github.com/WebAssembly/spec/blob/f607ec9a776a9e3425639f3cbe9b2d96bdc16b60/test/core/linking.wast#L395)

For us the change is optional, but if we accept it, requires the change in spectest runner (see wasmx/fizzy#750)

@gumb0
Copy link
Collaborator Author

gumb0 commented Apr 15, 2021

Some more comments about backporting WebAssembly#1287

@gumb0 gumb0 force-pushed the w3c-1.0-tests-backported-fizzy-0.8.0 branch 2 times, most recently from 59cd51e to 3833a3d Compare April 20, 2021 11:07
@gumb0
Copy link
Collaborator Author

gumb0 commented Jun 23, 2022

It looks too complicated to try to backport WebAssembly#1287 commit's changes applicable to 1.0, so we'll be skipping it (and other post-1.0-related test commits).

@gumb0 gumb0 closed this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants