Add explicit check for imported limits validity#762
Merged
Conversation
7b0609a to
6fd0096
Compare
Codecov Report
@@ Coverage Diff @@
## master #762 +/- ##
=======================================
Coverage 99.25% 99.25%
=======================================
Files 77 77
Lines 11740 11744 +4
=======================================
+ Hits 11653 11657 +4
Misses 87 87
Flags with carried forward coverage won't be shown. Click here to find out more.
|
6fd0096 to
f34043f
Compare
f34043f to
f8811f9
Compare
f8811f9 to
b39277a
Compare
Collaborator
Author
|
Split tests into a separate commit to show the error message change. |
chfast
approved these changes
Mar 17, 2021
axic
approved these changes
Mar 29, 2021
b39277a to
52defb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
provided imported table doesn't fit provided limits=>provided import's min limit is above import's max limit.memory.size() == min.limitin instantiate).