[test] Fix alignment of i32.store instruction in binary test#1312
Merged
rossberg merged 1 commit intoWebAssembly:masterfrom Apr 14, 2021
Merged
[test] Fix alignment of i32.store instruction in binary test#1312rossberg merged 1 commit intoWebAssembly:masterfrom
rossberg merged 1 commit intoWebAssembly:masterfrom
Conversation
rossberg
approved these changes
Apr 14, 2021
Member
rossberg
left a comment
rossberg
left a comment
There was a problem hiding this comment.
Ah, sorry, that probably got buried under a bulk of merge conflicts. (We keep having a lot of them for binary.wast. Maybe that indicates that we should split it up.)
gumb0
added a commit
to wasmx/wasm-spec
that referenced
this pull request
Apr 14, 2021
gumb0
added a commit
to wasmx/wasm-spec
that referenced
this pull request
Apr 15, 2021
gumb0
added a commit
to wasmx/wasm-spec
that referenced
this pull request
Apr 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same problem was already fixed once in #1261, but then was reintroduced in #1287.