Conversation
There was a problem hiding this comment.
Can you add a comment explaining the difference between a Trap and a Crash?
|
Addressed comments, PTAL. |
There was a problem hiding this comment.
Would it make sense to make error take (at, msg) as a tuple and a category string to simplify the exception handling pattern match below?
There was a problem hiding this comment.
Could do that, but I don't think introducing a constructor indirection is worth it here. Makes all creation sites slightly more verbose and saves a little bit in this single place.
|
Friendly ping. |
ml-proto/spec/eval.ml
Outdated
There was a problem hiding this comment.
"out of bounds" is a phrase we use to describe accesses that extend beyond the size. How about "memory size exceeded implementation limit"?
|
lgtm, with one wording nit above. |
|
Thanks! Wording nit addressed, merging. |
Distinguish different categories of errors
As discussed in the CG on November 12, 2019 and in WebAssembly#144. Specifically, all atomic accesses are now allowed to validate and execute normally on unshared memories and wait operations trap when used with unshared memories. The PR updates Overview.md and makes a best-effort attempt at updating the spec, making no changes when there is already a TODO for updating spec text. It also adds new TODO comments to the reference interpreter where changes will have to be made.
Add support for v128.const
Editorial updates to Overview.md
4 participants
This patch introduces different error exceptions to distinguish between static errors, traps, crashes, and assertion failures. It also does various other clean-ups around error handling.