Skip to content

refactor of int ops (i32/i64) into functor#147

Merged
sunfishcode merged 1 commit intoWebAssembly:masterfrom
naturaltransformation:master
Oct 21, 2015
Merged

refactor of int ops (i32/i64) into functor#147
sunfishcode merged 1 commit intoWebAssembly:masterfrom
naturaltransformation:master

Conversation

@naturaltransformation
Copy link
Contributor

A simple refactor of the i32 and i64 operators into a single functor

@rossberg
Copy link
Member

lgtm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment needs updating.

@sunfishcode
Copy link
Member

That works. Feel free to file a new issue for investigating the div_u/rem_u question and adding more tests if needed, or I can file it too, when I get a chance. Thanks!

sunfishcode added a commit that referenced this pull request Oct 21, 2015
refactor of int ops (i32/i64) into functor
@sunfishcode sunfishcode merged commit 570249b into WebAssembly:master Oct 21, 2015
Connicpu pushed a commit to Connicpu/wasm-spec that referenced this pull request May 11, 2020
As discussed in the CG on November 12, 2019 and in WebAssembly#144. Specifically,
all atomic accesses are now allowed to validate and execute normally
on unshared memories and wait operations trap when used with unshared
memories.

The PR updates Overview.md and makes a best-effort
attempt at updating the spec, making no changes when there is
already a TODO for updating spec text. It also adds new TODO comments
to the reference interpreter where changes will have to be made.
Connicpu pushed a commit to Connicpu/wasm-spec that referenced this pull request Jun 7, 2020
The data/elem index comes before the memory/table index.
ngzhian pushed a commit to ngzhian/spec that referenced this pull request Nov 4, 2021
WAVM/WAVM#220

    [simd] Add more literal tests for lane ops

    Remove some redundant tests BTW
dhil pushed a commit to dhil/webassembly-spec that referenced this pull request Mar 2, 2023
This updates the explainer text according to the new spec we agreed in
the 09-15-2020 CG meeting and discussions afterwards.

The following are modifications and clarifications we made after the
09-15-2020 CG meeting, and the relevant issue posts, if any:
https://github.com/WebAssembly/meetings/blob/master/main/2020/CG-09-15.md

- `catch_br` wasm renamed to `delegate` (WebAssembly#133)
- `rethrow` gains an immediate argument (WebAssembly#126)
- Removed dependences on the reference types proposal and the multivalue
  proposal. The multivalue proposal was previously listed as dependent
  because 1. `try` is basically a `block`, so it can have multivalue
  input/output 2. `br_on_exn` can extract multiple values from a
  `block`. We don't have `br_on_exn` anymore, and I'm not sure 1 is a
  strong enough reason to make it a dependence.
- Mention `rethrow` cannot rethrow exceptions caught by `unwind` (WebAssembly#142
  and WebAssembly#137)
- Mention some runtimes, especially web VMs, can attach stack traces to
  the exception object, implying stack traces are not required for all
  VMs
- Update label/validation rules for `delegate` and `rethrow` (WebAssembly#146)
- Finalize opcodes for `delegate` (0x18) and `catch_all` (0x19) (WebAssembly#145
  and WebAssembly#147)

I believe this resolves many previous issue threads, so I'll close them.
Please reopen them if you think there are things left for discussions in
those issues.

Resolves WebAssembly#113, resolves WebAssembly#126, resolves WebAssembly#127, resolves WebAssembly#128, resolves
WebAssembly#130, resolves WebAssembly#142, resolves WebAssembly#145, resolves WebAssembly#146, resolves WebAssembly#147.
alexcrichton pushed a commit to WebAssembly/wide-arithmetic that referenced this pull request Sep 19, 2025
Fix deeply nested prose breaking pdflatex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants