Allow trailing dot before exponent in float literal#226
Merged
Conversation
Member
|
LGTM, although I wonder why anybody would want this. |
Member
Author
|
Not sure, but @jfbastien was surprised it didn't work in sexpr-wasm. I guess it's commonly supported in C-like languages. |
Member
|
In C it's common to write With wasm it's not clearly as useful because you can't mix types and get conversions as C gives you. I therefore agree it's not useful for wasm per-se, but it's useful for people who are used to their trailing dot :-) |
binji
added a commit
that referenced
this pull request
Feb 1, 2016
Allow trailing dot before exponent in float literal
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
* Fixes the typing rule of CAUGHTadm as suggested in: WebAssembly/exception-handling#229 (comment) * Applying suggestion from PR WebAssembly#241 https://github.com/WebAssembly/exception-handling/pull/241/files/201ff276be6c458e7a819662eb2862bd475f2fcd..f97c9d108a999c3c3fd30f25554a113822bed1b8#r1030097793 * Applied suggestions from code review, fixed notation, also adding the missing _n to CAUGHTadm. The subscript is introduced by the changes in PR WebAssembly#226
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
…ly#226) - Add prose for reduction rules involving thrown exceptions. - Change administrative handler instructions and adding caught exceptions to the runtime stack. + In particular: * Switched to handler ::= (tagaddr? instr*)* | labelidx exn ::= tagaddr val* instr ::= … | handler_n{handler} instr* end | caught_n{exn} instr* end removing DELEGATEadm - Changed prose to just push and pop handlers and exceptions, in the runtime, in the execution steps of the instructions, in the formal overview, and partly in appendix/properties. - Apply suggestions from code review Co-authored-by: Heejin Ahn <aheejin@gmail.com> Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See WebAssembly/wabt#29