Test that the start function index space does not include imports.#241
Conversation
Contributor
|
Should we also add the |
Author
|
The other checks should detect an index space error, the start function can not have operands and the import does. |
The v8 encoding appears to be using it's imports-and-functions index space for the start function index encoding, so these tests check that tools are mapping it correctly.
jfbastien
added a commit
that referenced
this pull request
Feb 24, 2016
Test that the start function index space does not include imports.
ghost
deleted the
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
… everywhere. (WebAssembly#241) This addresses additional review comments to PR WebAssembly#222, that were made after it was merged. The last review comment in the discussion suggests to adjust all validation labels to use label types instead of just result types. Should address all occurrences of validation labels. Additionally adds a boolean catch_label to control frames in the validation algorithm, and some related functionality, fixing the cases for opcodes `catch` and `catch_all`. * Apply suggestions from code review Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org> Co-authored-by: Heejin Ahn <aheejin@gmail.com> * Reverting changes to typing of CAUGHTadm. Changes to this rule are now done in PR WebAssembly#244
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
* Fixes the typing rule of CAUGHTadm as suggested in: WebAssembly/exception-handling#229 (comment) * Applying suggestion from PR WebAssembly#241 https://github.com/WebAssembly/exception-handling/pull/241/files/201ff276be6c458e7a819662eb2862bd475f2fcd..f97c9d108a999c3c3fd30f25554a113822bed1b8#r1030097793 * Applied suggestions from code review, fixed notation, also adding the missing _n to CAUGHTadm. The subscript is introduced by the changes in PR WebAssembly#226
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v8 encoding appears to be using it's imports-and-functions index
space for the start function index encoding, so these tests check that
tools are mapping it correctly.