Conversation
Contributor
Author
|
Last part of #711 |
alexcrichton
reviewed
Feb 3, 2026
Collaborator
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
After thinking about this and #725 and #729, I think that TCP/UDP might be a good case for having wasip2/wasip3 all defined in the same file. There's subtle interactions with how these methods all work and having it all in one place I think will be beneficial. The lion's share of the internals here are all shared and the main differences are the I/O read/write bits, and those can be shepherded out to read/write mostly. Given that WDYT about moving wasip2_tcp.c to maybe tcp.c and going from there?
| errno = parse_err; | ||
| return -1; | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Around here, could this return -1 + ENOTSUPP if blocking is set to false? I think that'll need special handling here to ensure that case works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.